Fix comparison of User to other types. Closes #75.

This commit is contained in:
hugovk 2014-03-01 16:44:13 +02:00
parent 0d483234d4
commit f59d2cc680
2 changed files with 32 additions and 3 deletions

View file

@ -2864,10 +2864,16 @@ class User(_BaseObject):
return self.get_name()
def __eq__(self, another):
return self.get_name() == another.get_name()
if isinstance(another, User):
return self.get_name() == another.get_name()
else:
return False
def __ne__(self, another):
return self.get_name() != another.get_name()
if isinstance(another, User):
return self.get_name() != another.get_name()
else:
return True
def _get_params(self):
return {"user": self.get_name()}

View file

@ -198,10 +198,33 @@ class TestPyLast(unittest.TestCase):
self.assertGreaterEqual(len(albums), 0)
def test_user_equals_none(self):
# Arrange
lastfm_user = self.network.get_user(self.username)
# Act
value = (lastfm_user == None)
# Assert
self.assertFalse(value)
def test_user_not_equal_to_none(self):
# Arrange
lastfm_user = self.network.get_user(self.username)
# Act
value = (lastfm_user != None)
# Assert
self.assertTrue(value)
if __name__ == '__main__':
# suite = unittest.TestSuite()
# suite.addTest(TestPyLast('test_get_limitless_albums'))
# suite.addTest(TestPyLast('test_user_equals_none'))
# suite.addTest(TestPyLast('test_user_not_equal_to_none'))
# unittest.TextTestRunner().run(suite)
unittest.main()