Hirad/pylast
2
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Merge pull request #217 from pylast/fix-collect-nodes

Browse source 
Fix: _collect_nodes() break if there are no child nodes
This commit is contained in:
Hugo 2017-09-25 14:54:09 +03:00 committed by GitHub
parent 20d46a43b3 e19061a437
commit d6281e3829
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pylast/__init__.py
View file

@ -3945,6 +3945,9 @@ def _collect_nodes(limit, sender, method_name, cacheable, params=None):
doc = sender._request(method_name, cacheable, params) doc = sender._request(method_name, cacheable, params)
doc = cleanup_nodes(doc) doc = cleanup_nodes(doc)
# break if there are no child nodes
if not doc.documentElement.childNodes:
break
main = doc.documentElement.childNodes[0] main = doc.documentElement.childNodes[0]
if main.hasAttribute("totalPages"): if main.hasAttribute("totalPages"):

3
tests/test_pylast.py
View file

@ -911,8 +911,7 @@ class TestPyLast(unittest.TestCase):
lastfm_user = self.network.get_authenticated_user() lastfm_user = self.network.get_authenticated_user()
# Act/Assert # Act/Assert
# Skip the first one because Last.fm API is broken self.helper_validate_cacheable(lastfm_user, "get_friends")
# self.helper_validate_cacheable(lastfm_user, "get_friends")
self.helper_validate_cacheable(lastfm_user, "get_loved_tracks") self.helper_validate_cacheable(lastfm_user, "get_loved_tracks")
self.helper_validate_cacheable(lastfm_user, "get_neighbours") self.helper_validate_cacheable(lastfm_user, "get_neighbours")
self.helper_validate_cacheable(lastfm_user, "get_past_events") self.helper_validate_cacheable(lastfm_user, "get_past_events")