Fix serious cache key lookup performance problem
Checking if a request is cached or not took ~6sec / item vs <0.01sec now, because __contains__ wasn't definied for the _ShelfCacheBackend class and it iterated over each cache key on every check
This commit is contained in:
parent
a1e10e75cd
commit
d24100f2db
|
@ -713,6 +713,10 @@ class _ShelfCacheBackend(object):
|
|||
"""Used as a backend for caching cacheable requests."""
|
||||
def __init__(self, file_path=None):
|
||||
self.shelf = shelve.open(file_path)
|
||||
self.cache_keys = set(self.shelf.keys())
|
||||
|
||||
def __contains__(self, key):
|
||||
return key in self.cache_keys
|
||||
|
||||
def __iter__(self):
|
||||
return iter(self.shelf.keys())
|
||||
|
@ -721,6 +725,7 @@ class _ShelfCacheBackend(object):
|
|||
return self.shelf[key]
|
||||
|
||||
def set_xml(self, key, xml_string):
|
||||
self.cache_keys.add(key)
|
||||
self.shelf[key] = xml_string
|
||||
|
||||
|
||||
|
|
Loading…
Reference in a new issue