From 353e32bd6b7eb9cf3cd7be2797d344255df74707 Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Date: Wed, 22 May 2024 22:26:42 +0300 Subject: [PATCH 1/2] Fix expected result in test --- tests/test_track.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_track.py b/tests/test_track.py index db9c69c..8d8a275 100755 --- a/tests/test_track.py +++ b/tests/test_track.py @@ -140,7 +140,7 @@ class TestPyLastTrack(TestPyLastWithLastFm): # Assert found = False for track in similar: - if str(track.item) == "Madonna - Vogue": + if str(track.item) == "Cher - Strong Enough": found = True break assert found From 35b264bae471cfef1f13663d17ea4777c166240a Mon Sep 17 00:00:00 2001 From: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Date: Wed, 22 May 2024 22:29:05 +0300 Subject: [PATCH 2/2] Refactor --- tests/test_track.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/test_track.py b/tests/test_track.py index 8d8a275..db04d15 100755 --- a/tests/test_track.py +++ b/tests/test_track.py @@ -138,11 +138,7 @@ class TestPyLastTrack(TestPyLastWithLastFm): similar = track.get_similar() # Assert - found = False - for track in similar: - if str(track.item) == "Cher - Strong Enough": - found = True - break + found = any(str(track.item) == "Cher - Strong Enough" for track in similar) assert found def test_track_get_similar_limits(self) -> None: