From 8e99f2b04e3d5e647858cf25534fe935f175a812 Mon Sep 17 00:00:00 2001 From: Hugo Date: Mon, 18 Sep 2017 14:47:21 +0300 Subject: [PATCH 1/3] Use different artists for test_set_tags and test_remove_tags to avoid parallel test collisions --- tests/test_pylast.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_pylast.py b/tests/test_pylast.py index 45cbd8f..cc582a3 100755 --- a/tests/test_pylast.py +++ b/tests/test_pylast.py @@ -1803,7 +1803,7 @@ class TestPyLast(unittest.TestCase): def test_set_tags(self): # Arrange tags = ["sometag1", "sometag2"] - artist = self.network.get_artist("Test Artist") + artist = self.network.get_artist("Test Artist 2") artist.add_tags(tags) tags_before = artist.get_tags() new_tags = ["settag1", "settag2"] From 705eafbd3e3e22d670472483de5e24742f6c8711 Mon Sep 17 00:00:00 2001 From: Hugo Date: Mon, 18 Sep 2017 14:55:52 +0300 Subject: [PATCH 2/3] Print all warnings (-W all), and show prints (-s# disable all capturing) --- tox.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tox.ini b/tox.ini index 42f8433..ff9f1ed 100644 --- a/tox.ini +++ b/tox.ini @@ -15,7 +15,7 @@ deps = ipdb pytest-cov flaky -commands = py.test -v --cov pylast --cov-report term-missing {posargs} +commands = py.test -v -s -W all --cov pylast --cov-report term-missing {posargs} [testenv:venv] deps = ipdb From 618833e297c2aa3c577d2b7050028f7b6a045483 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mice=20P=C3=A1pai?= Date: Fri, 5 May 2017 10:39:04 +0200 Subject: [PATCH 3/3] Fix unclosed SSLSocket warning, Update credits --- pylast/__init__.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pylast/__init__.py b/pylast/__init__.py index daa1efe..fdd0cd9 100644 --- a/pylast/__init__.py +++ b/pylast/__init__.py @@ -33,8 +33,9 @@ import time import xml.dom __version__ = '1.9.0' -__author__ = 'Amr Hassan, hugovk' -__copyright__ = "Copyright (C) 2008-2010 Amr Hassan, 2013-2017 hugovk" +__author__ = 'Amr Hassan, hugovk, Mice Pápai' +__copyright__ = ('Copyright (C) 2008-2010 Amr Hassan, 2013-2017 hugovk, ' + '2017 Mice Pápai') __license__ = "apache2" __email__ = 'amr.hassan@gmail.com' @@ -1048,6 +1049,7 @@ class _Request(object): response_text = XML_ILLEGAL.sub("?", response_text) self._check_response_for_errors(response_text) + conn.close() return response_text def execute(self, cacheable=False):