Hirad/pylast
2
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Skip tests if Last.fm API still broken

Browse source
This commit is contained in:
hugovk 2016-04-23 15:46:49 +03:00
parent ea33074941
commit 4732bf3750
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/test_pylast.py
View file

@ -70,7 +70,7 @@ class TestPyLast(unittest.TestCase):
def skip_if_lastfm_api_broken(self, value): def skip_if_lastfm_api_broken(self, value):
"""Skip things not yet restored in Last.fm's broken API""" """Skip things not yet restored in Last.fm's broken API"""
if value is None: if value is None or len(value) == 0:
pytest.skip("Last.fm API is broken.") pytest.skip("Last.fm API is broken.")
@handle_lastfm_exceptions @handle_lastfm_exceptions
@ -926,7 +926,8 @@ class TestPyLast(unittest.TestCase):
lastfm_user = self.network.get_authenticated_user() lastfm_user = self.network.get_authenticated_user()
# Act/Assert # Act/Assert
self.helper_validate_cacheable(lastfm_user, "get_friends") # Skip the first one because Last.fm API is broken
# self.helper_validate_cacheable(lastfm_user, "get_friends")
self.helper_validate_cacheable(lastfm_user, "get_loved_tracks") self.helper_validate_cacheable(lastfm_user, "get_loved_tracks")
self.helper_validate_cacheable(lastfm_user, "get_neighbours") self.helper_validate_cacheable(lastfm_user, "get_neighbours")
self.helper_validate_cacheable(lastfm_user, "get_past_events") self.helper_validate_cacheable(lastfm_user, "get_past_events")
@ -1184,6 +1185,7 @@ class TestPyLast(unittest.TestCase):
tags = user.get_top_tags(limit=1) tags = user.get_top_tags(limit=1)
# Assert # Assert
self.skip_if_lastfm_api_broken(tags)
self.helper_only_one_thing_in_top_list(tags, pylast.Tag) self.helper_only_one_thing_in_top_list(tags, pylast.Tag)
@handle_lastfm_exceptions @handle_lastfm_exceptions
@ -1936,8 +1938,7 @@ class TestPyLast(unittest.TestCase):
similar = tag.get_similar() similar = tag.get_similar()
# Assert # Assert
if len(similar) == 0: self.skip_if_lastfm_api_broken(similar)
pytest.skip("Last.fm API is broken.")
found = False found = False
for tag in similar: for tag in similar:
if tag.name == "delta blues": if tag.name == "delta blues":