Hirad/pylast
2
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Merge pull request #244 from pylast/fix-cache-key-lookup-performance

Browse source 
Fix serious cache key lookup performance problem
This commit is contained in:
Hugo 2018-01-11 12:27:52 +02:00 committed by GitHub
parent a1e10e75cd d24100f2db
commit 423db55bd0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pylast/__init__.py
View file

@ -713,6 +713,10 @@ class _ShelfCacheBackend(object):
"""Used as a backend for caching cacheable requests.""" """Used as a backend for caching cacheable requests."""
def __init__(self, file_path=None): def __init__(self, file_path=None):
self.shelf = shelve.open(file_path) self.shelf = shelve.open(file_path)
self.cache_keys = set(self.shelf.keys())
def __contains__(self, key):
return key in self.cache_keys
def __iter__(self): def __iter__(self):
return iter(self.shelf.keys()) return iter(self.shelf.keys())
@ -721,6 +725,7 @@ class _ShelfCacheBackend(object):
return self.shelf[key] return self.shelf[key]
def set_xml(self, key, xml_string): def set_xml(self, key, xml_string):
self.cache_keys.add(key)
self.shelf[key] = xml_string self.shelf[key] = xml_string