Hirad/pylast
2
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Merge pull request #388 from pylast/rm-deprecations

Browse source
This commit is contained in:
Hugo van Kemenade 2022-02-27 16:17:06 +02:00 committed by GitHub
parent 7f4bea6f07 bb05699252
commit 26db2bc68b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 68 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
src/pylast/__init__.py
View file

@ -29,7 +29,6 @@ import shelve
import ssl import ssl
import tempfile import tempfile
import time import time
import warnings
import xml.dom import xml.dom
from http.client import HTTPSConnection from http.client import HTTPSConnection
from urllib.parse import quote_plus from urllib.parse import quote_plus
@ -1783,20 +1782,6 @@ class Artist(_Taggable):
) )
return self.listener_count return self.listener_count
def is_streamable(self):
"""Returns True if the artist is streamable: always False because Last.fm has
deprecated the Radio API."""
warnings.warn(
"Always returns False. Last.fm has deprecated the Radio API and will "
"it at some point. is_streamable() will be removed in pylast 5.0.0. "
"See https://www.last.fm/api/radio and "
"https://support.last.fm/t/"
"is-the-streamable-attribute-broken-it-always-returns-0/39723/3",
DeprecationWarning,
stacklevel=2,
)
return False
def get_bio(self, section, language=None): def get_bio(self, section, language=None):
""" """
Returns a section of the bio. Returns a section of the bio.
@ -2135,34 +2120,6 @@ class Track(_Opus):
loved = _number(_extract(doc, "userloved")) loved = _number(_extract(doc, "userloved"))
return bool(loved) return bool(loved)
def is_streamable(self):
"""Returns True if the artist is streamable: always False because Last.fm has
deprecated the Radio API."""
warnings.warn(
"Always returns False. Last.fm has deprecated the Radio API and will "
"it at some point. is_streamable() will be removed in pylast 5.0.0. "
"See https://www.last.fm/api/radio and "
"https://support.last.fm/t/"
"is-the-streamable-attribute-broken-it-always-returns-0/39723/3",
DeprecationWarning,
stacklevel=2,
)
return False
def is_fulltrack_available(self):
"""Returns True if the full track is available for streaming: always False
because Last.fm has deprecated the Radio API."""
warnings.warn(
"Always returns False. Last.fm has deprecated the Radio API and will "
"remove it at some point. is_fulltrack_available() will be removed in "
"pylast 5.0.0. See https://www.last.fm/api/radio and "
"https://support.last.fm/t/"
"is-the-streamable-attribute-broken-it-always-returns-0/39723/3",
DeprecationWarning,
stacklevel=2,
)
return False
def get_album(self): def get_album(self):
"""Returns the album object of this track.""" """Returns the album object of this track."""
if "album" in self.info and self.info["album"] is not None: if "album" in self.info and self.info["album"] is not None:

3
tests/test_artist.py
View file

@ -229,8 +229,6 @@ class TestPyLastArtist(TestPyLastWithLastFm):
mbid = artist1.get_mbid() mbid = artist1.get_mbid()
playcount = artist1.get_playcount() playcount = artist1.get_playcount()
with pytest.warns(DeprecationWarning):
streamable = artist1.is_streamable()
name = artist1.get_name(properly_capitalized=False) name = artist1.get_name(properly_capitalized=False)
name_cap = artist1.get_name(properly_capitalized=True) name_cap = artist1.get_name(properly_capitalized=True)
@ -240,7 +238,6 @@ class TestPyLastArtist(TestPyLastWithLastFm):
assert name.lower() == name_cap.lower() assert name.lower() == name_cap.lower()
assert url == "https://www.last.fm/music/radiohead" assert url == "https://www.last.fm/music/radiohead"
assert mbid == "a74b1b7f-71a5-4011-9441-d0b5e4122711" assert mbid == "a74b1b7f-71a5-4011-9441-d0b5e4122711"
assert isinstance(streamable, bool)
def test_artist_eq_none_is_false(self): def test_artist_eq_none_is_false(self):
# Arrange # Arrange

22
tests/test_track.py
View file

@ -118,28 +118,6 @@ class TestPyLastTrack(TestPyLastWithLastFm):
# Assert # Assert
assert duration >= 200000 assert duration >= 200000
def test_track_is_streamable(self):
# Arrange
track = pylast.Track("Nirvana", "Lithium", self.network)
# Act
with pytest.warns(DeprecationWarning):
streamable = track.is_streamable()
# Assert
assert not streamable
def test_track_is_fulltrack_available(self):
# Arrange
track = pylast.Track("Nirvana", "Lithium", self.network)
# Act
with pytest.warns(DeprecationWarning):
fulltrack_available = track.is_fulltrack_available()
# Assert
assert not fulltrack_available
def test_track_get_album(self): def test_track_get_album(self):
# Arrange # Arrange
track = pylast.Track("Nirvana", "Lithium", self.network) track = pylast.Track("Nirvana", "Lithium", self.network)