Hirad/pylast
2
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Fix serious cache key lookup performance problem

Browse source 
Checking if a request is cached or not took ~6sec / item vs <0.01sec now, because __contains__ wasn't definied for the _ShelfCacheBackend class and it iterated over each cache key on every check
This commit is contained in:
Mice Pápai 2017-05-05 10:51:26 +02:00
parent 281bb7c453
commit 2137605ced
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pylast/__init__.py
View file

@ -1070,6 +1070,10 @@ class _ShelfCacheBackend(object):
"""Used as a backend for caching cacheable requests.""" """Used as a backend for caching cacheable requests."""
def __init__(self, file_path=None): def __init__(self, file_path=None):
self.shelf = shelve.open(file_path) self.shelf = shelve.open(file_path)
self.cache_keys = set(self.shelf.keys())
def __contains__(self, key):
return key in self.cache_keys
def __iter__(self): def __iter__(self):
return iter(self.shelf.keys()) return iter(self.shelf.keys())
@ -1078,6 +1082,7 @@ class _ShelfCacheBackend(object):
return self.shelf[key] return self.shelf[key]
def set_xml(self, key, xml_string): def set_xml(self, key, xml_string):
self.cache_keys.add(key)
self.shelf[key] = xml_string self.shelf[key] = xml_string