Hirad/pylast
2
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Deprecate Artist.get_cover_image, they're no longer available from Last.fm

Browse source
This commit is contained in:
Hugo 2020-06-22 22:20:29 +03:00
parent 108e3dda44
commit 158273e0ae
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/pylast/__init__.py
View file

@ -1726,6 +1726,15 @@ class Artist(_BaseObject, _Taggable):
SIZE_SMALL SIZE_SMALL
""" """
warnings.warn(
"Artist.get_cover_image is deprecated and will be removed in a future "
"version. In the meantime, only default star images are available. "
"See https://github.com/pylast/pylast/issues/317 and "
"https://support.last.fm/t/api-announcement/202",
DeprecationWarning,
stacklevel=2,
)
if "image" not in self.info: if "image" not in self.info:
self.info["image"] = _extract_all( self.info["image"] = _extract_all(
self._request(self.ws_prefix + ".getInfo", cacheable=True), "image" self._request(self.ws_prefix + ".getInfo", cacheable=True), "image"

5
tests/test_artist.py
View file

@ -250,7 +250,10 @@ class TestPyLastArtist(TestPyLastWithLastFm):
# Act # Act
url = artist1.get_url() url = artist1.get_url()
mbid = artist1.get_mbid() mbid = artist1.get_mbid()
image = artist1.get_cover_image()
with pytest.warns(DeprecationWarning):
image = artist1.get_cover_image()
playcount = artist1.get_playcount() playcount = artist1.get_playcount()
streamable = artist1.is_streamable() streamable = artist1.is_streamable()
name = artist1.get_name(properly_capitalized=False) name = artist1.get_name(properly_capitalized=False)