Hirad/pylast
2
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Set limit to 50 by default, not 1

Browse source
This commit is contained in:
Hugo van Kemenade 2020-12-27 14:01:12 +02:00
parent 46a3dbf4a6
commit 08274028eb
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/pylast/__init__.py
View file

@ -1149,7 +1149,7 @@ class _BaseObject:
def _get_things(self, method, thing, thing_type, params=None, cacheable=True): def _get_things(self, method, thing, thing_type, params=None, cacheable=True):
"""Returns a list of the most played thing_types by this thing.""" """Returns a list of the most played thing_types by this thing."""
limit = params.get("limit", 1) limit = params.get("limit", 50)
seq = [] seq = []
for node in _collect_nodes( for node in _collect_nodes(
limit, self, self.ws_prefix + "." + method, cacheable, params limit, self, self.ws_prefix + "." + method, cacheable, params

11
tests/test_artist.py
View file

@ -131,6 +131,17 @@ class TestPyLastArtist(TestPyLastWithLastFm):
# Assert # Assert
assert len(things) == 100 assert len(things) == 100
def test_artist_top_albums_limit_default(self):
# Arrange
# Pick an artist with plenty of plays
artist = self.network.get_top_artists(limit=1)[0].item
# Act
things = artist.get_top_albums()
# Assert
assert len(things) == 50
def test_artist_listener_count(self): def test_artist_listener_count(self):
# Arrange # Arrange
artist = self.network.get_artist("Test Artist") artist = self.network.get_artist("Test Artist")